Login using email address #397
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmmrssa
requested changes
Jul 26, 2021
| @@ -50,20 +50,24 @@ const SignIn = () => { | |||
| } | |||
|
|
|||
| return ( | |||
| <form className='sign' onSubmit={handleSubmit(onSubmit)}> | |||
| <form className='sign' onSubmit={handleSubmit(onSubmit)} noValidate> | |||
There was a problem hiding this comment.
why is validation error removed?
| message: 'You must enter username' | ||
| message: 'You must enter email' | ||
| }, | ||
| pattern: { |
There was a problem hiding this comment.
email pattern will not be required as input type should do that
| @@ -69,21 +69,25 @@ const ForgotPassword = () => { | |||
|
|
|||
| return ( | |||
| <SignLayout> | |||
| <form className='sign'> | |||
| <form className='sign' noValidate> | |||
There was a problem hiding this comment.
validation should not be removed
There was a problem hiding this comment.
I removed noValidate and changed email field type to text.
| message: 'You must enter username' | ||
| message: 'You must enter email' | ||
| }, | ||
| pattern: { |
There was a problem hiding this comment.
pattern validation will not be required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #issue_number
Description
Login using email address on login, signup and forgot password screen.
Screenshots
Links and Curls
http://localhost:3000/login
http://localhost:3000/register
http://localhost:3000/forgot-password