fix(upload): align output, report problems #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
line-o
force-pushed
the
fix/114
branch
2 times, most recently
from
dbcd7aa
to
3af1e92
Compare
fixes eXist-db#114 When a upload operation fails in part or in total a non-zero exit code accompanied by a meaningful message will be added. Created collections and resources are now actually counted. With `--verbose` errors on resource and collection level are shown. In general output of upload operations is now better aligned and also colored if the terminal is capable of that. Improved utitily modules: - errors.js - recognize more network errors - recognize filesystem errors - recognize XMLRPC faults - export all error categorization helpers - add `formatErrorMessage` - connection.js - new helper `getServerUrl` returns db server URL - new helper `getUserInfo` returns user connecting to DB New utility modules: - account.js - `getAccountInfo`: turns raw XMLRPC db user data into AccountInfo - message.js - `logSucces`: helper to align operation success messages - `logFailure`: helper to align operation failure messages Adapt and improve tests.
duncdrum
approved these changes
Nov 21, 2023
|
🎉 This PR is included in version 1.9.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #114
When a upload operation fails in part or in total a non-zero exit code
accompanied by a meaningful message will be added.
Created collections and resources are now actually counted.
With
--verboseerrors on resource and collection level are shown.In general output of upload operations is now better aligned and also
colored if the terminal is capable of that.
Improved utitily modules:
formatErrorMessagegetServerUrlreturns db server URLgetUserInforeturns user connecting to DBNew utility modules:
getAccountInfo: turns raw XMLRPC db user data into AccountInfologSucces: helper to align operation success messageslogFailure: helper to align operation failure messagesAdapt and improve tests.