-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify configuration #5252
base: develop
Are you sure you want to change the base?
Simplify configuration #5252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a second look at my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5faad19
to
6aa5536
Compare
6aa5536
to
5ec8341
Compare
428e972
to
e25b0d9
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks completely fine to me! Thanks for this @reinhapa
Only the commit messages need to follow our commit message format then this can go in.
Or do you want to do further changes before this should be merged?
e25b0d9
to
91cee99
Compare
91cee99
to
b9d09b4
Compare
Quality Gate passedIssues Measures |
b9d09b4
to
8c7bea2
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@reinhapa Is this ready to go? |
Try to reduce complexity and sonar warnings