Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x.x] cardinality of CastExpression#toFunction #4976

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

line-o
Copy link
Member

@line-o line-o commented Jul 11, 2023

Description:

Backport of #4973 to eXist-6.x.x

Reference:

fixes #4971

Type of tests:

XQSuite tests

The argument must be of type xs:anyAtomic not item().
Moved the tests to its own module cast-constructor.xqm and
expanded the tests.
@line-o line-o requested review from a team, wolfgangmm, adamretter, dizzzz and reinhapa July 11, 2023 10:00
@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@adamretter
Copy link
Member

@line-o Would you mind changing the title of the PR please so that it matches the convention we have used previously?

@line-o
Copy link
Member Author

line-o commented Jul 11, 2023

The title of the PR, is the persistet anywhere?

@adamretter
Copy link
Member

is the persistet anywhere?

Yes it goes into the commit message for the merge commit.

@line-o
Copy link
Member Author

line-o commented Jul 11, 2023

And what would you like it to read instead?

@line-o
Copy link
Member Author

line-o commented Jul 15, 2023

Here is a set of merge commit messages from 5.x.x branch
Screenshot 2023-07-15 at 18 29 04
I neither see a pattern to follow nor the PR title anywhere.
@adamretter What exactly do you want me to do?

@line-o line-o changed the title Backport/4971 [6.x.x] Backport/4971 Jul 20, 2023
@line-o line-o changed the title [6.x.x] Backport/4971 [6.x.x] Backport 4971 Jul 20, 2023
@line-o line-o changed the title [6.x.x] Backport 4971 [6.x.x] cardinality of CastExpression#toFunction Jul 20, 2023
@line-o line-o added the bug issue confirmed as bug label Jul 20, 2023
@line-o line-o added this to the eXist-6.2.1 milestone Jul 20, 2023
@line-o
Copy link
Member Author

line-o commented Jul 20, 2023

I hope the title of the PR is now good to go @adamretter

Copy link
Member

@adamretter adamretter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@adamretter adamretter merged commit 3a39490 into eXist-db:develop-6.x.x Jul 21, 2023
7 of 16 checks passed
@line-o line-o deleted the backport/4971 branch July 21, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issue confirmed as bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants