-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent omission of results from collections with different index styles #4869
Conversation
extensions/indexes/range/src/main/java/org/exist/xquery/modules/range/Lookup.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small comments and suggestions.
exist-core/src/main/java/org/exist/xquery/pragmas/Optimize.java
Outdated
Show resolved
Hide resolved
extensions/indexes/range/src/test/xquery/range/multi-collection-search.xqm
Outdated
Show resolved
Hide resolved
extensions/indexes/range/src/main/java/org/exist/xquery/modules/range/Lookup.java
Outdated
Show resolved
Hide resolved
extensions/indexes/range/src/main/java/org/exist/xquery/modules/range/Lookup.java
Outdated
Show resolved
Hide resolved
nice work! |
The build is failing for now, once #4924 is merged the build will return to normal |
c7bb48b
to
26f47f3
Compare
SonarCloud Quality Gate failed. |
@marmoure please could you rebase? |
66dd907
to
60fa4ec
Compare
…ot just those that have a collection.xconf that uses the newer Lucene based Range Index Closes eXist-db#3620
…ith a variety of indexes
…ion in favour of newer Optimizable#canOptimizeSequence(Sequence) function
SonarCloud Quality Gate failed. 0 Bugs 84.5% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All LGTM now. Thanks.
@dizzzz I think this one is ready to land now. |
Fixes #3620
When performing a Search on a parent collection that has several sub-collections each with different types of indexes configured, The optimizer was optimizing the query without checking if all sub-collections were fit to be optimized.
#3620 has a nice test suit to illustrate this issue thanks to @joewiz. This PR now passes all of those tests.
This open source contribution to the exist project was commissioned by the Office of the Historian, U.S. Department of State, https://history.state.gov/.