Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference to temporary error in UnsupportedType exception #195

Merged

Conversation

srmainwaring
Copy link
Contributor

Partially completes #192

Resolve error raised by clang about a returning a reference to a temporary. Move creation of the error string to the constructor and store in member variable.

Copy link
Contributor

@MiguelBarro MiguelBarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelBarro MiguelBarro merged commit 3a10798 into eProsima:main Jun 29, 2023
4 checks passed
@srmainwaring srmainwaring deleted the prs/pr-unsupported-type-exception branch June 29, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants