Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid snapshot creation index inversion #479

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

greensky00
Copy link
Contributor

  • Since snapshot is created by the background commit thread, index inversion can happen if user explicitly calls manual creation API. In that case, the backgroudn thread will create a snapshot on an index that is older than the latest snapshot, which should not happen.

  • To avoid such a case, added a logic to check the request commit index and the latest snapshot's index.

* Since snapshot is created by the background commit thread, index
inversion can happen if user explicitly calls manual creation API.
In that case, the backgroudn thread will create a snapshot on
an index that is older than the latest snapshot, which should not
happen.

* To avoid such a case, added a logic to check the request commit
index and the latest snapshot's index.
@greensky00
Copy link
Contributor Author

#478

@greensky00 greensky00 merged commit 9de4522 into eBay:master Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant