Fix public usage requirements on CMake targets #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the include directory to the public includes for both the static and shared targets. It is necessary to do it for both the build and install interfaces, because the build interface will be used if the project is added as a submodule, but the install interface will be used if the project was added using a config. Fixes eBay#460.
JosiahWI
force-pushed
the
fix/target-includes
branch
from
b27182c
to
0f31c3d
Compare
JosiahWI
added a commit
to JosiahWI/trafficserver
that referenced
this pull request
Aug 22, 2023
This adds the experimental stek_share plugin. It will require eBay/NuRaft#462.
greensky00
approved these changes
Aug 27, 2023
JosiahWI
added a commit
to JosiahWI/trafficserver
that referenced
this pull request
Sep 15, 2023
This adds the experimental stek_share plugin. It will require eBay/NuRaft#462.
bneradt
pushed a commit
to apache/trafficserver
that referenced
this pull request
Sep 15, 2023
This adds the experimental stek_share plugin. The stek_share plugin will only build if CMake finds NuRaft. This will only work after eBay/NuRaft#462.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the include directory to the public includes for both the static and shared targets. It is necessary to do it for both the build and install interfaces, because the build interface will be used if the project is added as a submodule, but the install interface will be used if the project was added using a config.
Fixes #460.