Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: aws region pattern regex not matching il-central-1 #92

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: aws region pattern regex not matching il-central-1 #92

wants to merge 1 commit into from

Conversation

ivallhon
Copy link
Collaborator

@ivallhon ivallhon commented Sep 2, 2024

Bug fix:

The aws_region_pattern helper regex doesn't match the il-central-1 region, making the log forwarder fail to match log processing rules using it (e.g. CloudTrail logs).

  • Amends the aws_region_pattern regex to match the Israel region
  • Adds a unit test to validate all valid AWS regions match against the regex

@ivallhon ivallhon requested a review from sq2gxo September 2, 2024 08:57
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sq2gxo sq2gxo sq2gxo approved these changes

@kinbork kinbork Awaiting requested review from kinbork

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivallhon @sq2gxo