-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transitive edges #90
base: master
Are you sure you want to change the base?
Transitive edges #90
Conversation
@@ -3,23 +3,29 @@ package sbtprojectgraph | |||
import sbt.{ ProjectRef, ResolvedProject } | |||
|
|||
/** A node in a dependency tree of elements of type `A`. */ | |||
final case class Node[A](value: A, directDeps: Set[Dependency[Node[A]]], allDeps: Set[Dependency[A]], allEdges: Set[Edge[A]]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directDeps
variable was shadowed by val directDeps
definition below (the non-shadowed value is not used anywhere before)
@dwijnand anything I can add to move it forward? |
Hey @dot-vlad, sorry. My blocker here is that CI isn't working on Travis CI anymore and I don't have the bandwidth to fix that. Do you know of an easy way to migrate a Travis CI setup to GitHub Actions? |
@dwijnand after 10 minutes of googling, I didn't find anything outstanding but re-writting the yaml files. |
d2e72f5
to
197ad31
Compare
Hey @dot-vlad, found an ice-breaker for migrating to GitHub Actions (by bootstrapping my setup with a run of sbt-github-actions). So that's all running properly it seems (without CI publishing for now). I rebased and this is failing, do you think you could look at what's going on? |
Hi all, sorry for an unsolicited PR. In our project it is useful to look at the dependencies including the transitive ones.
I thought it will be helpful to push to the upstream. Also @er1c helped with some sbt-related settings.
Not sure about the scripted test though, was not able to make it working locally.
Included a little cleanup of the unused variables. Hope this is alright.