Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mail from email and name depending on Laravel environment variables #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xaviqv
Copy link

@xaviqv xaviqv commented Feb 20, 2017

I've found out two files where the mail from address is directly typed instead of using Laravel environment variables. I guess this is an error so I propose this change.

Anyway, thanks for your great project! Actually this is my first contribution but I hope it won't be the last!

@gdbhosale
Copy link
Member

@xaviqv Its a nice contribution.
Doing this will also have to update the .env file.
Please write code to installation for adding two new lines:

MAIL_FROM_NAME= LaraAdmin
MAIL_FROM_ADDRESS= [email protected]

Please add these changes and update your pull request. Will accept it.
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants