feat: add ability to connect to snowflake from core #7526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraggle
reviewed
Sep 19, 2024
| }) | ||
| .collect(); | ||
|
|
||
| Ok(explain_rows) |
There was a problem hiding this comment.
Seems a bit simple, is that working or is it just "stub" code ?
There was a problem hiding this comment.
yeah it works 🤷 Of course there will be a bit more code later, i.e check that those tables indeed map to tables we have synced and that the user making the query has the permission to use these tables, but I don't think there is a lot more to it
Fraggle
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part 1 of #7450
get_tables_used_by_query, which takes a query and returns a list of strings (fully qualified table identifiers)Next PR: add ability to query the database and parse results into a
Result<(Vec<QueryResult>, TableSchema), QueryDatabaseError>Risk
N/A (not used yet)
Deploy Plan
N/A