Dunify v0.0.3 #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinosaure
force-pushed
the
dune-universe-v0.0.3
branch
from
f3121fc
to
c482b11
Compare
dinosaure
force-pushed
the
dune-universe-v0.0.3
branch
from
c482b11
to
bbfd010
Compare
|
Looks good! For subsequent port, could you try to follow the workflow described here. That is, create a branch |
|
Also please do assign at least one of @Leonidas-from-XIV, @TheLortex or myself for review and await for approval before going further with the release. That will avoid back and forth between here and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to show what I did. I decided to use
dune-siteto be able to save some files into thesharedirectory asbrrdoes withoutdune. Let me know if it's good or not. /cc @NathanReb @Leonidas-from-XIV (sorry for the noise).