Integration test #25
Merged
Integration test #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdzwinel
commented
Jul 30, 2020
| @@ -8,7 +8,7 @@ | |||
| "scripts": { | |||
| "crawl": "node ./cli/crawl-cli", | |||
| "test": "npm run lint && tsc && npm run unit", | |||
| "unit": "find . -name \"*.test.js\" -not -path \"./node_modules/*\" -exec node {} \\;", | |||
| "unit": "node ./tests/runTests.js", | |||
There was a problem hiding this comment.
Some test failures didn't cause the whole testing to fail, so I had to write my own small runner to work around this.
I guess, at some point, I should consider just using one of the existing test runners and don't try to, yet again, roll out my own math library.
kdzwinel
commented
Jul 30, 2020
| @@ -20,7 +20,7 @@ | |||
| "test" | |||
| ], | |||
| "engines": { | |||
| "node": ">=10.0" | |||
| "node": ">=10.17" | |||
There was a problem hiding this comment.
unhandled-rejections=strict that allows us to throw when unhandled promise rejection happens is only available since 10.17
|
👍 thanks for adding this |
|
|
Thanks for double-checking @loco22loco! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds one simple integration test that visits multiple known websites and verifies collected data.
I confirmed that this test would have prevented #24 :