Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded outdated packages and fixed Gradle issues #26

Merged
merged 9 commits into from
Feb 9, 2024

Conversation

albertmoravec
Copy link
Contributor

@albertmoravec albertmoravec commented Feb 2, 2024

Upgraded Gradle to 7.6.3, unified configuration so it is consistent with our other packages and fixed a few issues due to outdated Gradle config.

Bumped pubspec.yaml dependencies.

Bumped Flutter CI to 3.16.7

Copy link
Member

@marianhlavac marianhlavac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, but it now brings some new untrivial constraints to drone-scanner. Can you pls accompany this PR with update in drone-scanner?

Drone scanner couldn't resolve deps, so I relaxed the version constraints and it ended up downgrading wakelock (why goddammit), required device_info_plus to go to 9.1.x and few more. Maybe you could ask @matejglejtek to help, at least with the reviews after changing the constraints.

Thx

Copy link
Member

@marianhlavac marianhlavac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with drone-scanner on Android, and on iOS just to be sure. Works as expected.

@albertmoravec albertmoravec merged commit 0b9fabe into master Feb 9, 2024
1 check passed
@albertmoravec albertmoravec deleted the chore/DT-2925-package-upgrade branch February 9, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants