Touch evidence, children and notes on node merge & add affected_ids to issues#index table cache #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caitmich
commented
Sep 3, 2024
Comment on lines
+45
to
53
| if relation == :activities | ||
| source_node.send(relation).update_all(column => target_node.id) | ||
| else | ||
| # update_all doesn't update timestamps so we need to do it manually | ||
| source_node.send(relation).update_all( | ||
| column => target_node.id, | ||
| :updated_at => Time.current | ||
| ) | ||
| end |
There was a problem hiding this comment.
Main changes. The rest is spacing updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After merging nodes,
:affectedin the cache keys. This leads to broken nodes#show links in the affected columnupdated_atdoes not get updated on node merge since we are usingupdate_all. This leads to broken #edit links (since they point to the old node)This PR adds
:affected_idsto the issues#index table cache key and addsupdated_at: Time.currentto the list of columns to update in merger.rb'smove_descendentsmethodCheck List