Feature issue entry association diff

[aapomm]

Summary

• Backported CSS changes from Pro
• Hide IssueLib widget
• Implement DiffedContent and specs
• Add delete_field method for the HasFields concern
• Implement fields_has_to_source to convert the hash of fields to Dradis-style item content.

Check List

- [ ] Added a CHANGELOG entry

[etdsoft]

I don't recall having reviewed this class before but several questions come to mind.

1. ".source_to_fields" and ".source_to_fields_array" sound a lot like one should be colling the other, instead you're duplicating code.
2. what's parse_fieldless_string used for?

I first noticed the use of "source" which I wasn't a fan of, but fine, it's our own internal speak. But then in the last method you use "_string" instead of "_source" and I don't that works (arguably I don't understand that method either).

[aapomm]

".source_to_fields" and ".source_to_fields_array" sound a lot like one should be colling the other, instead you're duplicating code.

Fixed ✅

what's parse_fieldless_string used for?

This method handles strings that are out side the Dradis fields format (#[Field]#\nValue\n...). This method solves the problem: if I have the following content in an issue

asdf

#[Title]#
Issue#1

How will asdf appear when the user switches to the Fields view?

I first noticed the use of "source" which I wasn't a fan of, but fine, it's our own internal speak. But then in the last method you use "_string" instead of "_source" and I don't that works (arguably I don't understand that method either).

I've renamed the method to parse_fields_without_headers(source) to better describe the method.