Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken events in Bridgeless mode (React Native New Architecture) #2370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robik
Copy link

@robik robik commented Sep 13, 2024

This PR fixes broken event emitting in React Native new architecture.

EDIT: This is breaking change, and mostly acts as a preview. I will try to come up with a solution for it if time allows.

This is a partial solution, and requires:

@pigeonmal
Copy link

I have test this patch with new arch react native 0.75.3. But i got this kotlin error :
MusicService.kt error: unresolved reference: reactContext

@robik
Copy link
Author

robik commented Sep 16, 2024

I have test this patch with new arch react native 0.75.3. But i got this kotlin error : MusicService.kt error: unresolved reference: reactContext

This probably is caused by the fact that the old RN is used (RN patch was not applied or it was not built from source)

@pigeonmal
Copy link

Thanks for your reply, and how can i fix that ?

My steps :

@pigeonmal
Copy link

Yes the only file i not have the same as you is settings.gradle (i have the default one). If add your modifications, i have an other error :

`Could not determine the dependencies of task ':react-native:packages:react-native:ReactAndroid:hermes-engine:configureBuildForHermes'.

Could not create task ':react-native:packages:react-native:ReactAndroid:hermes-engine:installCMake'.
Could not find sdkmanager executable.`

@lovegaoshi
Copy link
Contributor

so u r having compilation issues. if u dont add that in, ie. https://reactnative.dev/contributing/how-to-build-from-source, ur not compiling RN and not applying any changes. this is outside the scope of this PR and u should seek help in the general RN community.
im not going to pretend compiling RN is easy. its a PITA and im too sane now to troubleshoot someone elses env setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants