fix: added startForeground to onCreate #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badiozam
added a commit
to badiozam/react-native-track-playah
that referenced
this pull request
Jan 26, 2021
This was referenced Jan 26, 2021
|
We've made this change in the past and it caused other crashes, I'd like to see more testing in different types of apps before merging this. |
|
@bang9 how has this been working for you over this time? |
|
@dcvz I attached ANR graph
|
|
We'll pull this in @bang9 and we'll send it out with the next release v2.0.1 and we can see how the change performs in different apps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #620 #524 #473 #391
ANR graph changes since the fork was applied (released on 13 October 2020).
