Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on instrumenting unsupported types for the Fuzzer #108030

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Warn on instrumenting unsupported types for the Fuzzer #108030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/libraries/Fuzzing/DotnetFuzzing/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,13 @@ await DownloadArtifactAsync(

if (instrumentCoreLib)
{
// The instrumentation itself uses 'Marshal.AllocHGlobal', so attempting to instrument it will result in a stackoverflow at runtime.
if (fuzzer.TargetCoreLibPrefixes.FirstOrDefault(prefix => "System.Runtime.InteropServices.Marshal".StartsWith(prefix, StringComparison.OrdinalIgnoreCase)) is { } invalidPrefix)
{
throw new Exception($"Please specify a more specific prefix than '{invalidPrefix}'. " +
"For example, if you want to instrument 'System.Convert', specify the full type name instead of 'System'.");
}

yield return ("System.Private.CoreLib.dll", string.Join(' ', fuzzer.TargetCoreLibPrefixes));
}
}
Expand Down
Loading