Allow deactivation to be triggered during activation, clean up deactivation flow #9116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
changed the title
ReubenBond
force-pushed
the
fix/activationdata-lifecycle
branch
from
24d2e0c
to
deb9725
Compare
ReubenBond
force-pushed
the
fix/activationdata-lifecycle
branch
from
deb9725
to
3df01ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up activation lifecycle around shutdown, removing some duplication and improving hygiene around cancellation.
It enables deactivation to be triggered while a grain is still activating, eliminating the
"Calling DeactivateOnIdle from within OnActivateAsync is not supported"message. When deactivation is triggered, theCancellationTokenpassed to the ongoingOnActivateAsyncwill be canceled.This PR also fixes a possible
NullReferenceExceptionwhen a silo is shutting down ungracefully and a grain is disposed without first being deactivated, which can happen during ungraceful shutdown.Microsoft Reviewers: Open in CodeFlow