Switch to pre-built Cassandra Docker image #9076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed `Cassandra.dockerfile` and related custom image build code. Updated `CassandraContainer.cs` to use a pre-built Cassandra image from Docker Hub, specified by the `CASSANDRAVERSION` environment variable.
|
Adds about a minute to the test run on the build server, too. |
|
Test failures appear to be in tests unrelated to the changes in this PR |
ReubenBond
reviewed
Jul 24, 2024
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
Cassandra.dockerfileand related custom image build code. UpdatedCassandraContainer.csto use a pre-built Cassandra image from Docker Hub, specified by theCASSANDRAVERSIONenvironment variable.Using the base image without the prior config changes increases a local run of all the tests from 18 sec. to about 70 sec. Annoying, but not terrible.
We could look at replacing the config file with a transformed version but I don't know how stable that would be with future versions of Cassandra.
The test run on the build server should let us know if this is acceptable speed there.
Microsoft Reviewers: Open in CodeFlow