Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not attempt to sign Microsoft.Build.UnGAC.exe on dotnet core msbuild #10672

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Do not attempt to sign Microsoft.Build.UnGAC.exe on dotnet core msbuild #10672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion eng/Signing.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<Project>
<ItemGroup>
<ItemsToSign Include="$(VisualStudioSetupInsertionPath)Microsoft.Build.UnGAC.exe" />
<!-- Do not include VS setup insertion files when not building on desktop. The Vsix generation targets do not get imported,
mmitche marked this conversation as resolved.
Show resolved Hide resolved
and thus this file is not populated to VisualStudioSetupInsertionPath -->
<ItemsToSign Include="$(VisualStudioSetupInsertionPath)Microsoft.Build.UnGAC.exe" Condition="'$(MSBuildRuntimeType)' != 'Core'" />

<ItemsToSign Include="$(ArtifactsDir)\xsd\Update-MSBuildXsds.ps1" />

Expand Down