Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all precompiled query tests to the same collection. #34692

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

AndriySvyryd
Copy link
Member

This avoids running them in parallel as assembly loading is not thread safe.

@AndriySvyryd AndriySvyryd requested a review from a team September 16, 2024 23:01
@roji
Copy link
Member

roji commented Sep 17, 2024

@AndriySvyryd can you provide some context on this? Were we getting test failures because of this (which ones)?

@AndriySvyryd
Copy link
Member Author

I don't have the full details, but a test in
PrecompiledQuerySqlServerTest
failed once when loading the compiled assembly because an internal dictionary was modified during enumeration.

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. It seems weird to me and maybe worth understanding, but no objection.

@AndriySvyryd AndriySvyryd merged commit 0f74a57 into main Sep 18, 2024
7 checks passed
@AndriySvyryd AndriySvyryd deleted the FixPrecompiledTests branch September 18, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants