[Blazor] Update WebAssembly.DevServer to serve the Blazor-Environment header
#57971
+22
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiercn
reviewed
Sep 19, 2024
javiercn
approved these changes
Sep 19, 2024
mkArtakMSFT
approved these changes
Sep 19, 2024
|
/backport to release/9.0-rc2 |
|
Started backporting to release/9.0-rc2: https://github.com/dotnet/aspnetcore/actions/runs/10949630835 |
10 tasks
halter73
approved these changes
Sep 20, 2024
| else if (applyCopHeaders && ctx.Request.Path.StartsWithSegments("/_framework") && !ctx.Request.Path.StartsWithSegments("/_framework/blazor.server.js") && !ctx.Request.Path.StartsWithSegments("/_framework/blazor.web.js")) | ||
| { | ||
| var fileExtension = Path.GetExtension(ctx.Request.Path); | ||
| if (string.Equals(fileExtension, ".js", StringComparison.Ordinal)) |
There was a problem hiding this comment.
Why didn't an analyzer catch this previously? Also, it's more consistent to ignore case.
Suggested change
| if (string.Equals(fileExtension, ".js", StringComparison.Ordinal)) | |
| if (string.Equals(fileExtension, ".js", StringComparison.OrdinalIgnoreCase)) |
I can't think of a reason a request would come in with an uppercase .JS extension, but file extensions generally are case insensitive, and the dev server would still serve the correct file. StartsWithSegments also defaults to OrdinalIgnoreCase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the dev server no longer calls
UseBlazorFrameworkFiles(), we need to manually add theBlazor-Environmentheader when applicable.Fixes #57941