Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for sentinel value when setting HTTP/3 error code #57934

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Check for sentinel value when setting HTTP/3 error code #57934

wants to merge 5 commits into from
+87 −4

Commits on Sep 18, 2024

  1. Check for sentinel value when setting HTTP/3 error code 

    If no error code has been set, `IProtocolErrorFeature.Error` will be `-1`.  If we pass that through verbatim, it will be caught by validation in the setter (ironically, of the same property on the same feature object), resulting in an exception and a Critical (but apparently benign) log message.

Fixes dotnet#57933
    @amcasey
    amcasey committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d87133f View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Cover a couple other consumers of IProtocolErrorCodeFeature

    @amcasey
    amcasey committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    117003a View commit details
    Browse the repository at this point in the history

  2. Add explanatory comment 

    Co-authored-by: James Newton-King <[email protected]>
    @amcasey @JamesNK
    amcasey and JamesNK committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    1393ecc View commit details
    Browse the repository at this point in the history

  3. Use a property

    @amcasey
    amcasey committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0f72ac7 View commit details
    Browse the repository at this point in the history

  4. Add a regression test

    @amcasey
    amcasey committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f42dbcc View commit details
    Browse the repository at this point in the history