fix: Missing returns

Could've lead to invalid resources in the state
dodevops · Feb 21, 2023 · 2cb9297 · 2cb9297
1 parent dea61c8
commit 2cb9297
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/internal/provider/ldap_object_resource.go b/internal/provider/ldap_object_resource.go
@@ -103,6 +103,7 @@ func (L *LDAPObjectResource) Create(ctx context.Context, request resource.Create
 			"Can not add resource",
 			fmt.Sprintf("LDAP server reported: %s", err),
 		)
+		return
 	}
 	data.ID = data.DN
 	response.Diagnostics.Append(response.State.Set(ctx, &data)...)
@@ -156,6 +157,7 @@ func (L *LDAPObjectResource) Update(ctx context.Context, request resource.Update
 				"Can not add resource",
 				fmt.Sprintf("LDAP server reported: %s", err),
 			)
+			return
 		}
 	} else {
 		var stateAttributes map[string][]string
@@ -199,6 +201,7 @@ func (L *LDAPObjectResource) Update(ctx context.Context, request resource.Update
 				"Can not modify entry",
 				fmt.Sprintf("LDAP server reported: %s", err),
 			)
+			return
 		}
 	}
 	planData.ID = planData.DN