Skip to content
This repository has been archived by the owner on Aug 29, 2018. It is now read-only.

Lot of changes to make it more flexible. #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bartoszhernas
Copy link

  • Added ability to specify headers
  • Added ability to do single rest request without mapping to objects (data translator without entity mapping)
  • Added method to get EntityConfiguration in ResponseTransformers and fixed issue with json_decode
  • Added method to set requestType and ability to send json requests to server.

Class is still backwards compatible

@@ -91,7 +115,7 @@ public function execute(Request $request)
}

$result = curl_exec($ch);

xdebug_var_dump($result);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably remove this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, sorry

Wysłane z iPhone'a / Sent from iPhone

Pozdrawiam / Best regards

Bartosz Hernas

http://hernas.pl

On 24 gru 2013, at 20:16, Colin Hutchinson [email protected] wrote:

In lib/Doctrine/REST/Client/Client.php:

@@ -91,7 +115,7 @@ public function execute(Request $request)
}

     $result = curl_exec($ch);

  •    xdebug_var_dump($result);
    
    should probably remove this


Reply to this email directly or view it on GitHub.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for removal

@jwage
Copy link
Member

jwage commented Jan 11, 2014

👍 just a few small coding standards comments.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants