Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENGDOCS-2228 #20940

Merged
merged 3 commits into from
Sep 19, 2024
Merged

ENGDOCS-2228 #20940

merged 3 commits into from
Sep 19, 2024

Conversation

aevesdocker
Copy link
Contributor

Description

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@netlify Netlify
Copy link

netlify bot commented Sep 19, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit e315830
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/66ec2a9178d014000886e2ab
😎 Deploy Preview https://deploy-preview-20940--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/compose Relates to docker-compose.yml spec or docker-compose binary area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/cli Relates to the CLI client area/security area/get-started Relates to get started and onboarding docs area/contrib Relates to the Docker style guide and contribution guidelines area/guides labels Sep 19, 2024
@aevesdocker aevesdocker marked this pull request as ready for review September 19, 2024 15:18
craig-osterhout
craig-osterhout approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@aevesdocker aevesdocker merged commit 9d975a9 into docker:main Sep 19, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-osterhout craig-osterhout craig-osterhout approved these changes

Assignees
No one assigned
Labels
area/cli Relates to the CLI client area/compose Relates to docker-compose.yml spec or docker-compose binary area/contrib Relates to the Docker style guide and contribution guidelines area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/get-started Relates to get started and onboarding docs area/guides area/security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aevesdocker @craig-osterhout