Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

ECS: Redid security group generation for LBs #2215

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ECS: Redid security group generation for LBs #2215

wants to merge 2 commits into from

Commits on Jan 11, 2023

  1. ECS: Created slightly-complicated-service test 

    Summary:
Can be used to test service-service interaction, and stacks with more than one service

Test Plan:
This is a unit test

Signed-off-by: Nitzan Raz <[email protected]>
    @BackSlasher
    BackSlasher committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    fdf4ebf View commit details
    Browse the repository at this point in the history

  2. ECS: Creating special security groups for ingress, instead of adding … 

    …the ingress rule to other security groups

Solves docker-archive#1783
Previously, the ECS stack included an ingress rule to allow LB to reach the tasks.
However, it added this ingress rule toe very Docker network security group, meaning other tasks on the same Docker network, possibly sensitive, were accessible externally.
We now create a new security group for port assignments for every service that has ports, and attach that security group only to that service.
This prevents other tasks in the same Docker networks are not accessible externally.

Signed-off-by: Nitzan Raz <[email protected]>
    @BackSlasher
    BackSlasher committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    dfe2ac8 View commit details
    Browse the repository at this point in the history