DMN 1.5 - date increments in loops #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmn-tck/contributors please review. |
|
Reviewed and test pass on the Trisotech Engine |
|
Thanks @SimonRinguette . Apols, I have a few more sanity checks to throw in here. Apols. On their way. Assertions that types other than number/date are not permitted. |
|
Btw, as a small note here. These tests did not have any actual ranges as iterations contexts. I have added some as the spec does refer to 'ranges' of numbers and dates, but, I have a feeling the absence of actual ranges in these tests was the result of some early discussion whereby it was agreed that the spec did not permit 'range' types here. At any rate, the tests now have actual range values. |
StrayAlien
changed the title
|
@dmn-tck/contributors please re-review after the latest updates. |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dates may now be used by loops. Some simple tests for prove this is possible and that the increment is by a single day