Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMN 1.4 - 1150-boxed-conditional #601

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

StrayAlien
Copy link
Contributor

No description provided.

@opatrascoiu
Copy link
Contributor

@StrayAlien They look good to me.

We should probably add a few more:

  • then and else branches do not return the same type (e.g. one number the other one string) and typeRefs (e.g. on TConditional or branches) to check for type mismatch.
  • nested if then else

@StrayAlien
Copy link
Contributor Author

Thanks @opatrascoiu - fair call. I guess similar tests could be added to the other new boxed expression as well. I was going to leave the typeRef checking as a follow on PR to the 'domain' checking PR, but, it'll not hurt to get them in here. Thanks.

@SimonRinguette
Copy link
Contributor

I validated these tests

@baldimir
Copy link
Collaborator

If we need more tests, they could be created as a separate PR to not hold these.

@baldimir baldimir merged commit 40c6ef2 into dmn-tck:master Oct 19, 2023
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants