-
Notifications
You must be signed in to change notification settings - Fork 538
Conversation
0028c31
to
e1f9433
Compare
Job PR-359/3 is complete. |
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
=======================================
Coverage 84.25% 84.25%
=======================================
Files 94 94
Lines 8313 8313
=======================================
Hits 7004 7004
Misses 1309 1309
|
Job PR-359/4 is complete. |
Job PR-359/5 is complete. |
Job PR-359/6 is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a readme.md or some rst file explaining how to use this training script (steps for compilation and cmd to run) and the expected result
Job PR-359/7 is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I haven't gone through all the code in tools/cooccur.cc. Some comments so far
Will update this PR (rebase) to follow the structure adopted in #384 once merged. |
Job PR-359/8 is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments
Job PR-359/9 is complete. |
Job PR-359/10 is complete. |
Job PR-359/12 is complete. |
* Add GloVe * Address comments * Address comments * Add dropout * Autoformat
Description
This adds an implementation of GloVe. Unlike the original C implementation with asynchronous AdaGrad we used synchronous batched AdaGrad to make use of GPU. This also adds optimized C++ tools
vocab_count
andcooccur
to construct the input for thetrain_glove.py
script. Both tools make use of a (single-machine) map-reduce pattern to scale better than the single-threaded versions of https://github.com/stanfordnlp/GloVe .Checklist
Essentials
Changes
vocab_count
andcooccur
toolsComments