Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default_path support in repoPaths configuration #345

Conversation

rmacklin
Copy link
Contributor

@rmacklin rmacklin commented Mar 7, 2024

Summary

Now that we support the more general :owner/:repo template configuration (#343), the prior default_path functionality (#327) is redundant - e.g. this configuration:

default_path: ~/code/repos

can be achieved equivalently with:

:owner/:repo: ~/code/repos/:repo

Thus, we are removing the default_path syntax.

How did you test this change?

I updated the automated tests to show how the default_path test case is covered with the :owner/:repo syntax.

Now that we support the more general `:owner/:repo` template
configuration (85a75fe), the prior
`default_path` functionality (d9ef14a)
is redundant - e.g. this configuration:
```
default_path: ~/code/repos
```
can be achieved equivalently with:
```
:owner/:repo: ~/code/repos/:repo
```

Thus, we are removing the `default_path` syntax.
README.md Show resolved Hide resolved
@dlvhdr dlvhdr merged commit ab52fdf into dlvhdr:main Mar 8, 2024
2 checks passed
@rmacklin rmacklin deleted the remove-default_path-from-repoPaths-configuration branch March 8, 2024 13:40
@rmacklin
Copy link
Contributor Author

rmacklin commented Mar 8, 2024

Heads up @markfeinstein @ushmz @Arinono since you are/were using default_path - in the next version of gh-dash you'll need to tweak your repoPaths configuration as in the example above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants