feat(approve): Add PR approval cmd (#399)

README.md

@@ -183,7 +183,7 @@ keybindings:
 The list of available builtin commands are:
 
 1. `universal`: up, down, firstLine, lastLine, togglePreview, openGithub, refresh, refreshAll, pageDown, pageUp, nextSection, prevSection, search, copyurl, copyNumber, help, quit
-2. `prs`: assign, unassign, comment, diff, checkout, close, ready, reopen, merge, watchChecks, viewIssues
+2. `prs`: approve, assign, unassign, comment, diff, checkout, close, ready, reopen, merge, watchChecks, viewIssues
 3. `Issues`: assign, unassign, comment, close, reopen, viewPrs
 
 #### Defining custom keybindings

ui/components/prsidebar/approve.go

@@ -0,0 +1,54 @@
+package prsidebar
+
+import (
+	"fmt"
+	"os/exec"
+
+	tea "github.com/charmbracelet/bubbletea"
+	"github.com/dlvhdr/gh-dash/v4/ui/components/prssection"
+	"github.com/dlvhdr/gh-dash/v4/ui/constants"
+	"github.com/dlvhdr/gh-dash/v4/ui/context"
+)
+
+func (m *Model) approve(comment string) tea.Cmd {
+	pr := m.pr.Data
+	prNumber := pr.GetNumber()
+	taskId := fmt.Sprintf("pr_approve_%d", prNumber)
+	task := context.Task{
+		Id:           taskId,
+		StartText:    fmt.Sprintf("Approving pr #%d", prNumber),
+		FinishedText: fmt.Sprintf("pr #%d has been approved", prNumber),
+		State:        context.TaskStart,
+		Error:        nil,
+	}
+
+	commandArgs := []string{
+		"pr",
+		"review",
+		"-R",
+		pr.GetRepoNameWithOwner(),
+		fmt.Sprint(prNumber),
+		"--approve",
+	}
+	if comment != "" {
+		commandArgs = append(commandArgs, "--body", comment)
+	}
+
+	startCmd := m.ctx.StartTask(task)
+	return tea.Batch(startCmd, func() tea.Msg {
+		c := exec.Command("gh", commandArgs...)
+
+		err := c.Run()
+		if err != nil {
+		}
+		return constants.TaskFinishedMsg{
+			SectionId:   m.sectionId,
+			SectionType: prssection.SectionType,
+			TaskId:      taskId,
+			Err:         err,
+			Msg: prssection.UpdatePRMsg{
+				PrNumber: prNumber,
+			},
+		}
+	})
+}

ui/components/prsidebar/prsidebar.go

@@ -24,6 +24,7 @@ type Model struct {
 	width     int
 
 	isCommenting  bool
+	isApproving   bool
 	isAssigning   bool
 	isUnassigning bool
 
@@ -38,6 +39,7 @@ func NewModel(ctx context.ProgramContext) Model {
 		pr: nil,
 
 		isCommenting:  false,
+		isApproving:   false,
 		isAssigning:   false,
 		isUnassigning: false,
 
@@ -71,6 +73,25 @@ func (m Model) Update(msg tea.Msg) (Model, tea.Cmd) {
 				return m, nil
 			}
 
+			m.inputBox, taCmd = m.inputBox.Update(msg)
+			cmds = append(cmds, cmd, taCmd)
+		} else if m.isApproving {
+			switch msg.Type {
+
+			case tea.KeyCtrlD:
+				if len(strings.Trim(m.inputBox.Value(), " ")) != 0 {
+					cmd = m.approve(m.inputBox.Value())
+				}
+				m.inputBox.Blur()
+				m.isApproving = false
+				return m, cmd
+
+			case tea.KeyEsc, tea.KeyCtrlC:
+				m.inputBox.Blur()
+				m.isApproving = false
+				return m, nil
+			}
+
 			m.inputBox, taCmd = m.inputBox.Update(msg)
 			cmds = append(cmds, cmd, taCmd)
 		} else if m.isAssigning {
@@ -147,7 +168,7 @@ func (m Model) View() string {
 	s.WriteString("\n\n")
 	s.WriteString(m.renderActivity())
 
-	if m.isCommenting || m.isAssigning || m.isUnassigning {
+	if m.isCommenting || m.isApproving || m.isAssigning || m.isUnassigning {
 		s.WriteString(m.inputBox.View())
 	}
 
@@ -288,7 +309,7 @@ func (m *Model) SetWidth(width int) {
 }
 
 func (m *Model) IsTextInputBoxFocused() bool {
-	return m.isCommenting || m.isAssigning || m.isUnassigning
+	return m.isCommenting || m.isAssigning || m.isApproving || m.isUnassigning
 }
 
 func (m *Model) GetIsCommenting() bool {
@@ -317,6 +338,24 @@ func (m *Model) getIndentedContentWidth() int {
 	return m.width - 4
 }
 
+func (m *Model) GetIsApproving() bool {
+	return m.isApproving
+}
+
+func (m *Model) SetIsApproving(isApproving bool) tea.Cmd {
+	if !m.isApproving && isApproving {
+		m.inputBox.Reset()
+	}
+	m.isApproving = isApproving
+	m.inputBox.SetPrompt("Approve with comment...")
+	m.inputBox.SetValue("LGTM")
+
+	if isApproving {
+		return tea.Sequence(textarea.Blink, m.inputBox.Focus())
+	}
+	return nil
+}
+
 func (m *Model) GetIsAssigning() bool {
 	return m.isAssigning
 }

ui/keys/prKeys.go

@@ -10,6 +10,7 @@ import (
 )
 
 type PRKeyMap struct {
+	Approve     key.Binding
 	Assign      key.Binding
 	Unassign    key.Binding
 	Comment     key.Binding
@@ -24,6 +25,10 @@ type PRKeyMap struct {
 }
 
 var PRKeys = PRKeyMap{
+	Approve: key.NewBinding(
+		key.WithKeys("v"),
+		key.WithHelp("v", "approve"),
+	),
 	Assign: key.NewBinding(
 		key.WithKeys("a"),
 		key.WithHelp("a", "assign"),
@@ -72,6 +77,7 @@ var PRKeys = PRKeyMap{
 
 func PRFullHelp() []key.Binding {
 	return []key.Binding{
+		PRKeys.Approve,
 		PRKeys.Assign,
 		PRKeys.Unassign,
 		PRKeys.Comment,
@@ -97,6 +103,8 @@ func rebindPRKeys(keys []config.Keybinding) error {
 		var key *key.Binding
 
 		switch prKey.Builtin {
+		case "approve":
+			key = &PRKeys.Approve
 		case "assign":
 			key = &PRKeys.Assign
 		case "unassign":

ui/ui.go

@@ -272,6 +272,14 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 
 		case m.ctx.View == config.PRsView:
 			switch {
+			case key.Matches(msg, keys.PRKeys.Approve):
+				m.sidebar.IsOpen = true
+				cmd = m.prSidebar.SetIsApproving(true)
+				m.syncMainContentWidth()
+				m.syncSidebar()
+				m.sidebar.ScrollToBottom()
+				return m, cmd
+
 			case key.Matches(msg, keys.PRKeys.Assign):
 				m.sidebar.IsOpen = true
 				cmd = m.prSidebar.SetIsAssigning(true)