Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated GermaNet API to version 13.1.0 #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

updated GermaNet API to version 13.1.0 #14

wants to merge 2 commits into from

Conversation

matlaj
Copy link

@matlaj matlaj commented Jul 22, 2020

Solves #13

@ukp-svc-jenkins
Copy link

Can one of the admins verify this patch?

@reckart
Copy link
Member

reckart commented Jul 23, 2020

Jenkins, can you test this please?

@logological
Copy link
Member

@reckart, this PR is going to make the tests fail on UKP's Jenkins instance because it has access only to GermaNet 7. Here's how you need to fix this:

  1. Identify the person at UKP who is responsible for our GermaNet licence. This used to be me; I handed over duties to @chmeyer but I understand he's gone now.
  2. The responsible person should request a copy of GermaNet 15, which will require Iryna to physically sign a licence agreement.
  3. The GermaNet folks will e-mail Iryna a download link for GermaNet. (They refuse to e-mail the link to anyone other than the licence signatory.) Iryna needs to send this link to the responsible person.
  4. The responsible person should download GermaNet 15, add it to UKP's data repository (file server, wiki, etc.), and then notify you, or whoever else is responsible for Jenkins.
  5. Whoever is responsible for Jenkins should put a copy of the GermaNet 15 database somewhere where Jenkins can read it and update Jenkins's local copy of the DKPro LSR resources.xml file to point to it.

@reckart
Copy link
Member

reckart commented Jul 23, 2020

@logological I've posted it to the folks and hope somebody reports back here :

@reckart
Copy link
Member

reckart commented Jul 23, 2020

@logological the best option would be to create a mini dummy germanet for the unit test and to remove the depenency on having the actual germanet on the test server.

@logological
Copy link
Member

@logological the best option would be to create a mini dummy germanet for the unit test and to remove the depenency on having the actual germanet on the test server.

This would be possible, though I think DKPro Similarity has GermaNet tests of its own that will need to be rewritten for the dummy GermaNet.

@reckart
Copy link
Member

reckart commented Jul 23, 2020

Only when/if it is upgraded to a new DKPro LSR version ;)

@logological
Copy link
Member

@logological I've posted it to the folks and hope somebody reports back here :

@reckart: Sorry, you've posted what to what folks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants