Add limited Okta connection pooling #139
Merged
+179
−134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR introduces limited connection pooling for requests from Access to Okta. The intent is to avoid creating excessive connections, e.g. in case of Okta API degradation resulting in timeouts. Although the aiohttp docs for
ClientSession
state that "it is suggested you use a single session for the lifetime of your application to benefit from connection pooling," this isn't feasible due to the synchronous nature of the Access Flask app. Instead, we introduce a session with each async event loop to call the Okta API. This should at least consolidate retries and paginated requests to a single connection.Reviewing
Hide whitespace, since most of the changed lines are simply indented.