Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proof of concept for mul_tr #1387

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

proof of concept for mul_tr #1387

wants to merge 11 commits into from

Conversation

fangs124
Copy link
Contributor

I saw issue #1254. Attempted to implement it following the implementation for tr_mul. I'm not quire sure why the original hidden function was called xx_mul_to_unit (specifically the xx part), but I made a corresponding function yy_mul_to_uninit.

Opening this pull request mainly to gather feedback, and if all is good I should be able to write other variations of the functions in ops.rs such as mul_ad, mul_tr_to, etc.

I also also wanted to add a test similar to tr_mul_is_transpose_then_mul was for tr_mul, except for the new mul_tr function. I'm not used to writing tests, and especially not the proptest library. I was able to write a test, but I had to resort to physically transposing a column vector for the test.

Not really a programmer by trade, new to github. Feedback welcomed.

fangs124 and others added 11 commits April 22, 2024 17:36
Fixed a (presumed) typo in documentation in matrix_view.rs.

Previously it says fixed_view and fixed_slice returns a matrix with `(R::dim(), CView::dim())` consecutive components. I just changed R to RView, because presumably this is a typo.
Fixed a (presumed) typo in documentation in matrix_view.rs.

Previously it says fixed_view and fixed_slice returns a matrix with `(RView, CView)` consecutive components. As per-input, and after re-reading the documentation and source code. Seems like RView and CView should be used instead of RView::dim() and CViem::dim().
Fixed spacing in documentation.
added mut_tr and the corresponding hidden yy_mul_to_uninit function.
added a test for mul_tr to verify that we get m.mul_tr(v) is m*v.transpose(). also changed the name of the previous test for tr_mul to clarify which side of the multiplication is being transposed.
Fixed a typo.. oops.
Fixed a typo in documentation in matrix_view.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant