ecdsa-multikey v1.0.0 #1

kezike · 2023-02-14T15:58:14Z

Version 1.0.0 of ecdsa-multikey:

Implementation of ECDSA key pair generation with curves P-256, P-384, and P-521
Implementation of ECDSA sign and verify methods
Tests for ECDSA key pair generation with curves P-256, P-384, and P-521
Tests for ECDSA sign and verify methods

…d missing secret and public keys in createSigner and createVerifier respectively; incorporated EcdsaCurve and EcdsaHash enums;

… errors for importing and exporting key pairs; incorporated constants

…ixed call to createSigner and createVerifier

davidlehn

Please also fix issues from npm run lint.

.github/workflows/main.yml

karma.conf.cjs

lib/factory.js

package.json

lib/index.js

lib/serialize.js

…library; updated mock key data; updated package.json

…ion comments

kezike · 2023-02-22T12:30:05Z

@gannan08 The Codecov CI job is failing because of issues with the uploader, per this job run result. From my research, this may have to do with an outdated Codecov token. Have we encountered this error in the past?

dlongley

Thanks, this is looking really good! I just have a few simplifications / nits to apply.

lib/crypto-browser.js

lib/factory.js

lib/serialize.js

lib/helpers.js

lib/constants.js

lib/helpers.js

lib/index.js

.github/workflows/main.yml

…verage

…tes to uint8arrays

…object

dlongley

Looks like a couple of suggestions were missed from before, but then we should be good to go!

dlongley · 2023-02-22T23:08:05Z

lib/constants.js

+export const MULTICODEC_P256_SECRET_KEY_HEADER = 0x8626;
+// Multicodec p384-priv header (0x1307 varint -> 0x8726 hex)
+export const MULTICODEC_P384_SECRET_KEY_HEADER = 0x8726;
+// Multicodec p521-priv header (0x1308 varint -> 0x8826 hex)
+export const MULTICODEC_P521_SECRET_KEY_HEADER = 0x8826;


This looks like it wasn't applied yet.

lib/helpers.js

dlongley

Thanks! @gannan08 let me know if you need me to merge and release this or if you will.

gannan08 · 2023-02-27T18:47:06Z

@dlongley Can you please merge and release.

kezike added 22 commits February 4, 2023 16:14

added constants, helpers, and core/browser ecdsa lib files

2e7f75e

added factory and serialization lib files and updated package.json

9d80c4c

updated index.js with proper functionality

ff755c8

added constants

99bd482

added constants for ecdsa curves and hash algorithms

b087b90

incorporated constants into helper code

b9fcffd

added helper functions to encode key pair into multibase

53b7467

added file to convert key pair into multikey

a885424

added id property to input of createSigner and createVerifier; handle…

a60eebc

…d missing secret and public keys in createSigner and createVerifier respectively; incorporated EcdsaCurve and EcdsaHash enums;

included type and controller in exported key pairs; throw appropriate…

9b12905

… errors for importing and exporting key pairs; incorporated constants

modified browser binding in package.json; added multiformats library

027f74a

fixed error message of stringToUint8Array function

4374a8f

include complete set of multikey properties in generated key pairs; f…

7ab64d4

…ixed call to createSigner and createVerifier

removed unnecessary comma

0210145

added mock data; added initial set of tests for ecdsa multikey

caa0089

fixed constants import in ecdsa multikey test

0c49d37

added ecdsa sign and verify tests

cd66010

replace all relevant instances of "private" to "secret"

1dcae0a

updated readme

6d83cca

use ALGORITHM constant in remaining instances

c05dacb

added script to convert varint to hex

88bc648

remove outdated node-browser compatibility test

85a9026

davidlehn reviewed Feb 15, 2023

View reviewed changes

kezike changed the base branch from main to initial February 15, 2023 19:45

kezike added 6 commits February 15, 2023 15:19

simplified multicodec header constants

bc0751f

improved output of util/varint-conversions.js

6d253ac

added useful utility script for key operations

ef1a967

fixed _ensurePublicKeyEncoding by using latest version of multicodec …

00b6ce3

…library; updated mock key data; updated package.json

fixes lint errors; removes unnecessary code and constants; adds funct…

22c15a8

…ion comments

test github workflow on node version 18.x

8d15b13

kezike added 5 commits February 21, 2023 17:51

moved varint from dependencies to devDependencies in package.json

1c6d7e0

changed ecdsa type array to set and moved out of toMultikey function

73313f9

improved code coverage

9022fcb

fixed lint errors

b665c4e

removed outdated comment

4ae2fc9

This was referenced Feb 22, 2023

Test need for bitstring compression #2

Open

Match multikey headers between public key and secret key #3

Closed

Switch npm package from multicodec to multiformats #4

Closed

gannan08 requested a review from dlongley February 22, 2023 16:20

dlongley requested changes Feb 22, 2023

View reviewed changes

davidlehn reviewed Feb 22, 2023

View reviewed changes

.github/workflows/main.yml Outdated Show resolved Hide resolved

.github/workflows/main.yml Outdated Show resolved Hide resolved

.github/workflows/main.yml Outdated Show resolved Hide resolved

kezike added 7 commits February 22, 2023 13:48

fixed keys in readme

e6e93d9

remove codecov upload directive in github action ci worklow

9127aa0

fix copyright header in source code

d73e775

added minor style tweaks

d2610fe

removed unnecessary ci run on node version 18 for karma, lint, and co…

d67e7af

…verage

refactored representation of ecdsa curve header constants from raw by…

a0d13e0

…tes to uint8arrays

removed unnecessary reference to webcrypto property in global crypto …

9a9e05a

…object

kezike requested a review from dlongley February 22, 2023 21:04

dlongley requested changes Feb 22, 2023

View reviewed changes

kezike added 2 commits February 23, 2023 02:04

Update remaining ecdsa curve header constants.

ef1e22e

Changed nested if statement to compound and statement.

8716a20

kezike requested review from dlongley, gannan08 and davidlehn February 23, 2023 19:19

dlongley approved these changes Feb 23, 2023

View reviewed changes

dlongley merged commit 377688a into initial Feb 27, 2023

dlongley deleted the v1.0.0 branch February 27, 2023 23:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ecdsa-multikey v1.0.0 #1

ecdsa-multikey v1.0.0 #1

kezike commented Feb 14, 2023

davidlehn left a comment

kezike commented Feb 22, 2023 •

edited

Loading

dlongley left a comment

dlongley left a comment

dlongley Feb 22, 2023

dlongley left a comment

gannan08 commented Feb 27, 2023

ecdsa-multikey v1.0.0 #1

ecdsa-multikey v1.0.0 #1

Conversation

kezike commented Feb 14, 2023

davidlehn left a comment

Choose a reason for hiding this comment

kezike commented Feb 22, 2023 • edited Loading

dlongley left a comment

Choose a reason for hiding this comment

dlongley left a comment

Choose a reason for hiding this comment

dlongley Feb 22, 2023

Choose a reason for hiding this comment

dlongley left a comment

Choose a reason for hiding this comment

gannan08 commented Feb 27, 2023

kezike commented Feb 22, 2023 •

edited

Loading