ICRC-39: extract icrc-39_batch_calls #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plitzenberger
changed the title
plitzenberger
force-pushed
the
feature/icrc-25-remove-batch-calls
branch
from
e60440a
to
25cb837
Compare
plitzenberger
changed the base branch from
main
to
feature/icrc-25-separate-canister-calls
plitzenberger
requested review from
frederikrothenberger,
przydatek and
jsamol
plitzenberger
force-pushed
the
feature/icrc-25-remove-batch-calls
branch
from
780cb53
to
fc1e8d3
Compare
plitzenberger
force-pushed
the
feature/icrc-25-separate-canister-calls
branch
from
e3f8264
to
57be97b
Compare
Base automatically changed from
feature/icrc-25-separate-canister-calls
to
main
December 8, 2023 13:27
plitzenberger
force-pushed
the
feature/icrc-25-remove-batch-calls
branch
from
fc1e8d3
to
d2ffe73
Compare
frederikrothenberger
changed the title
|
@plitzenberger : This PR now needs updating with a different number (because of #116 ). |
The processing of additional requests after a failure is also changed to avoid footguns resulting from partially successful batches.
frederikrothenberger
force-pushed
the
feature/icrc-25-remove-batch-calls
branch
from
4fbb78e
to
e102136
Compare
frederikrothenberger
changed the title
I assigned it ICRC-39. |
|
@plitzenberger: I changed the processing of additional requests after a failure to avoid footguns resulting from partially successful batches. |
plitzenberger
commented
Jan 4, 2024
frederikrothenberger
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to extract the following standard extensions:
This is a collaborative change by @frederikrothenberger and @plitzenberger