Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix cdylib crate name logic #3926

Merged
merged 2 commits into from
Sep 26, 2024
Merged

fix: Fix cdylib crate name logic #3926

merged 2 commits into from
Sep 26, 2024

Conversation

adamspofford-dfinity
Copy link
Contributor

@adamspofford-dfinity adamspofford-dfinity commented Sep 25, 2024 •
edited
Loading

The current crate selection logic assumes crate name == package name. This is only true for bins, not libs.

Fixes #3919

@adamspofford-dfinity adamspofford-dfinity requested a review from a team as a code owner September 25, 2024 22:50
@adamspofford-dfinity adamspofford-dfinity merged commit bc98b43 into master Sep 26, 2024
296 checks passed
@adamspofford-dfinity adamspofford-dfinity deleted the spofford/lib-name-fix branch September 26, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrading to DFX 0.23.0 failing to build canisters - No crate X found
2 participants
@adamspofford-dfinity @ericswanson-dfinity