feat: Diagnose failure to follow dfx 0.11 upgrade steps #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfx-json
approved these changes
Jun 28, 2023
mmicu
pushed a commit
to mmicu/sdk
that referenced
this pull request
Jul 1, 2023
If project was last deployed with dfx <= 0.10, and upgrade steps for dfx 0.11 were not followed, `dfx deploy` with dfx >= 0.11 will fail with an error about duplicate assets. This PR makes dfx detect this case and display upgrade steps. Fixes https://dfinity.atlassian.net/browse/SDK-870
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If project was last deployed with dfx <= 0.10, and upgrade steps for dfx 0.11 were not followed,
dfx deploywith dfx >= 0.11 will fail with an error about duplicate assets. This PR makes dfx detect this case and display upgrade steps.Fixes https://dfinity.atlassian.net/browse/SDK-870
How Has This Been Tested?
Added an e2e test
Checklist: