Skip to content

Commit

Permalink
Address review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
vincent-dfinity committed Aug 31, 2024
1 parent b377290 commit 7dc4dfb
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 12 deletions.
18 changes: 7 additions & 11 deletions src/dfx/src/commands/extension/list.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,32 +17,28 @@ pub struct ListOpts {

pub fn exec(env: &dyn Environment, opts: ListOpts) -> DfxResult<()> {
let mgr = env.get_extension_manager();
let extensions;

let result;
if opts.available || opts.catalog_url.is_some() {
let runtime = Runtime::new().expect("Unable to create a runtime");
extensions = runtime.block_on(async {
let extensions = runtime.block_on(async {
mgr.list_available_extensions(opts.catalog_url.as_ref())
.await
})?;

result = display_extension_list(
display_extension_list(
&extensions,
"No extensions available.",
"Available extensions:",
);
)
} else {
extensions = mgr.list_installed_extensions()?;
let extensions = mgr.list_installed_extensions()?;

result = display_extension_list(
display_extension_list(
&extensions,
"No extensions installed.",
"Installed extensions:",
);
};

result
)
}
}

fn display_extension_list(
Expand Down
2 changes: 1 addition & 1 deletion src/dfx/src/commands/extension/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ pub enum SubCommand {
Uninstall(uninstall::UninstallOpts),
/// Execute an extension.
Run(run::RunOpts),
/// List installed or remote extensions.
/// List installed or available extensions.
List(list::ListOpts),
}

Expand Down

0 comments on commit 7dc4dfb

Please sign in to comment.