Support reinstalling canisters (SNS) #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchpop
force-pushed
the
@anchpop/support-reinstall
branch
4 times, most recently
from
b72649f
to
b004c02
Compare
sesi200
reviewed
May 23, 2024
anchpop
force-pushed
the
@anchpop/support-reinstall
branch
from
b004c02
to
c751dcf
Compare
sesi200
previously approved these changes
May 24, 2024
sesi200
reviewed
May 24, 2024
| @@ -62,6 +63,11 @@ pub struct MakeUpgradeCanisterProposalOpts { | |||
| /// Path to the binary file containing argument to post-upgrade method of the new canister WASM. | |||
| #[arg(long, conflicts_with = "canister_upgrade_arg")] | |||
| canister_upgrade_arg_path: Option<String>, | |||
|
|
|||
| /// The install mode. | |||
| #[arg(long, short, default_value("install"), | |||
There was a problem hiding this comment.
This disagrees with If the flag is not passed, the canister is upgraded instead (the old behavior). from the PR description. Also, it changes the default behaviour. IMO we need a very good reason to change what it does by default
anchpop
force-pushed
the
@anchpop/support-reinstall
branch
from
c751dcf
to
1649509
Compare
anchpop
force-pushed
the
@anchpop/support-reinstall
branch
from
1649509
to
ed77290
Compare
Co-authored-by: Adam Spofford <[email protected]>
sesi200
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously there was no way to send a UpgradeSnsControlledCanister proposal that reinstalls a canister with quill. This MR adds a
--modeflag that can be used for this purpose. The flag is required.Fixes NNS1-3063
How Has This Been Tested?
Automated tests have been adjusted to test all 3 cases
Checklist