Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A note and another strategy for ID-based deduplication #3526

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

oggy-dfin
Copy link
Member

Bogdan had a neat idea of how to extend the window-based ID deduplication approach. In the process of writing it up, I noticed that i didn't write anything about the backpressure when the capacity within the window is reached, so I added that.

Thank you for your contribution to the IC Developer Portal. This repo contains the content for https://internetcomputer.org and the ICP Developer Documentation, https://internetcomputer.org/docs/.

If you are submitting a Pull Request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:

Copy link
Contributor

@robin-kunzler robin-kunzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for improving this further @oggy-dfin and @bogwar for the nice idea! Approving - only had a minor suggestion, see above.

@oggy-dfin oggy-dfin merged commit 64ba7a7 into master Sep 25, 2024
3 of 4 checks passed
@oggy-dfin oggy-dfin deleted the oggy-idempotency-window-alternative branch September 25, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants