Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all Dev Docs to use relative links #2850

Merged
merged 7 commits into from
May 1, 2024
Merged

Conversation

jessiemongeon1
Copy link
Contributor

Addresses issue #2821

Thank you for your contribution to the IC Developer Portal.
Before submitting your Pull Request, please make sure that:

@jessiemongeon1 jessiemongeon1 requested review from a team as code owners April 30, 2024 18:35
@jessiemongeon1 jessiemongeon1 changed the title Update all dev docs to use relative links Update all Dev Docs to use relative links Apr 30, 2024
Copy link
Contributor

@dfx-json dfx-json left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I'm curious about is if the use of relative urls is triggering the problem of failed redirects. i.e. when we have a redirect defined, click on a link, and get a 404, only to navigate to that url directly and it works. I'm still trying to trace down the cause of that issue

@jessiemongeon1 jessiemongeon1 merged commit 16c4b4c into master May 1, 2024
4 checks passed
@jessiemongeon1 jessiemongeon1 deleted the update-relative branch May 1, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants