-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update security best practices with journaling #2356
Update security best practices with journaling #2356
Commits on Jan 18, 2024
-
Update security best practices with journaling
- Update how handle risks of outcalls to possibly untrusted canisters. - Update how to handle traps. - Add journaling section
Configuration menu - View commit details
-
Copy full SHA for d8cc528 - Browse repository at this point
Copy the full SHA d8cc528View commit details
Commits on Jan 29, 2024
-
Add journaling impl to rust-canister-development-security-best-practi…
…ces.md Reference the GoldDAO/gldt-swap implementation as an example of journaling.
Configuration menu - View commit details
-
Copy full SHA for f511dbb - Browse repository at this point
Copy the full SHA f511dbbView commit details
Commits on Feb 13, 2024
-
Update docs/developer-docs/security/rust-canister-development-securit…
…y-best-practices.md Accept Robin's suggestion to fix a typo in the text he wrote. Co-authored-by: Robin Künzler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7bf8b31 - Browse repository at this point
Copy the full SHA 7bf8b31View commit details -
Lower the level of Journaling Section in rust-canister-development-se…
…curity-best-practices.md Lower the section level of Journaling. Co-authored-by: Robin Künzler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9467697 - Browse repository at this point
Copy the full SHA 9467697View commit details
Commits on Feb 20, 2024
-
Update link to be more permanent
Old link was to a branch that had the underlying commit changed. The new tag link is fixed to a commit as long as normal version tag conventions are followed by the project.
Configuration menu - View commit details
-
Copy full SHA for d37080d - Browse repository at this point
Copy the full SHA d37080dView commit details
Commits on Apr 2, 2024
-
Security best practices / Journaling: Invoke guaranteed message order…
…ing in recovery Apply guaranteed message ordering to simplify example recovery process.
Configuration menu - View commit details
-
Copy full SHA for e53f6b6 - Browse repository at this point
Copy the full SHA e53f6b6View commit details -
Security-best-practices/journaling: Emphasize manual recovery for led…
…gers Emphasize manual recovery. This is because ICP ledger and ICRC ledgers make it difficult to determine whether a particular transaction has succeeded in an automated way.
Configuration menu - View commit details
-
Copy full SHA for 0b8139e - Browse repository at this point
Copy the full SHA 0b8139eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e0af220 - Browse repository at this point
Copy the full SHA e0af220View commit details -
Security-best-practices / Journaling: Another note on manually recovery
Add another note on encouraging manual recovery when finding out the result of a call is difficult to automate.
Configuration menu - View commit details
-
Copy full SHA for e4910c9 - Browse repository at this point
Copy the full SHA e4910c9View commit details -
Security-best-practices / Journaling: Add an internal link
Co-authored-by: Robin Künzler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4568b84 - Browse repository at this point
Copy the full SHA 4568b84View commit details -
Security-best-practices/Journaling: Detail retries
Add details on idempotent retries for task flows.
Configuration menu - View commit details
-
Copy full SHA for 3d04fea - Browse repository at this point
Copy the full SHA 3d04feaView commit details -
Security-best-practices/Journaling: Improve journaling example
Give more context for journal example structures and flows and clarify the examples.
Configuration menu - View commit details
-
Copy full SHA for f351e74 - Browse repository at this point
Copy the full SHA f351e74View commit details
Commits on Apr 4, 2024
-
Security-best-practices/callback-cleanup: Fix missing text
Fix missing text in callback cleanup section. Co-authored-by: Roel Storms <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a7f3320 - Browse repository at this point
Copy the full SHA a7f3320View commit details -
Security-best-practices/Journaling: Add clarification on trap handling
Add clarification that results may be lost if a trap occurs AND there is no self-call to commit it. Co-authored-by: oggy-dfin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ceae487 - Browse repository at this point
Copy the full SHA ceae487View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f60ed9 - Browse repository at this point
Copy the full SHA 6f60ed9View commit details -
Security-best-practices/Journaling: Improve wording
Co-authored-by: Roel Storms <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f8dbdc5 - Browse repository at this point
Copy the full SHA f8dbdc5View commit details -
Security-best-practices/Journaling: Improve wording
Co-authored-by: Roel Storms <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7d23528 - Browse repository at this point
Copy the full SHA 7d23528View commit details
Commits on Apr 24, 2024
-
Security-best-practices/Journaling: Improve wording
Suggestion from @roelstorms. Co-authored-by: Roel Storms <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4ac7190 - Browse repository at this point
Copy the full SHA 4ac7190View commit details -
Security-best-practices/Journaling: Improve wording
Suggestion from @oggy-dfin. Co-authored-by: Robin Künzler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1f67a3b - Browse repository at this point
Copy the full SHA 1f67a3bView commit details -
Security-best-practices/Journaling: Improve wording
Suggestion from @roelstorms. Co-authored-by: Roel Storms <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0b812dd - Browse repository at this point
Copy the full SHA 0b812ddView commit details -
Security-best-practices/Journaling: Improve wording
Suggestion from @roelstorms. Co-authored-by: Roel Storms <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0e99e92 - Browse repository at this point
Copy the full SHA 0e99e92View commit details -
Security-best-practices/Journaling: Add tx uniqueness requirement
Add uniqueness requirement for transaction hash.
Configuration menu - View commit details
-
Copy full SHA for 543a6db - Browse repository at this point
Copy the full SHA 543a6dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a8e016 - Browse repository at this point
Copy the full SHA 2a8e016View commit details -
Security-best-practices/Journaling: Remove example section
Remove section `Example journaling structures and flows`. Readers should refer to GoldDAO example instead.
Configuration menu - View commit details
-
Copy full SHA for 9dc6f9b - Browse repository at this point
Copy the full SHA 9dc6f9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8764170 - Browse repository at this point
Copy the full SHA 8764170View commit details