Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisions to sns-asset-canister.md #1631

Merged
merged 6 commits into from
Jul 5, 2023
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ This section is relevant if your project contains an asset canister and describe

:::info

In this document, the term **upgrade** refers to deploying an upgraded version of a canister's Wasm file.
In this document, the term **upgrade** refers to deploying an upgraded version of a canister's WebAssembly module.

The term **update** refers to changing or updating the assets stored within an SNS asset canister.
The term **update** refers to changing or updating the assets stored within an asset canister.
:::

## Deploying an asset canister
Expand All @@ -34,16 +34,10 @@ To deploy an asset canister, any canister in the `dfx.json` file can be set as `
An example of configuring an asset canister within the `dfx.json` file can be found below:

```
{
"canisters": {
"assets": {
jessiemongeon1 marked this conversation as resolved.
Show resolved Hide resolved
"build": "",
"candid": "candid/assets.did",
"type": "assets",
"wasm": "./assets.wasm.gz"
"source": [],
"type": "assets"
}
}
}
```


Expand Down Expand Up @@ -81,7 +75,7 @@ During the SNS launch, control of the asset canister must be handed over to the

Once the asset canister has been handed over to the SNS, only the governance canister should have `Commit` rights, and principals in the whitelist should have `Prepare` rights. The developer who configured and deployed the SNS should have their permissions removed during the SNS launch.

If the whitelist needs to be adapted or changed, the SNS can call `take_ownership` via a proposal, which must be added as a custom proposal type. This will clear all permissions, and give only the SNS governance canister `Commit` permissions.
If the whitelist needs to be adapted or changed, it is recommended that the SNS calls `take_ownership` via a proposal, which must be added as a custom proposal type. This will clear all permissions, and give only the SNS governance canister `Commit` permissions. If the SNS does not call `take_ownership`, a user cannot verify that all changes to the assets have been approved by an SNS proposal.
jessiemongeon1 marked this conversation as resolved.
Show resolved Hide resolved

### Granting permissions

Expand Down