-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to SNS docs #2 (WIP) #1622
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
docs/developer-docs/integrations/sns/launching/launch-summary.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/launching/launch-summary.md
Outdated
Show resolved
Hide resolved
jessiemongeon1
approved these changes
Jun 26, 2023
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
dprats
commented
Jun 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed broken link
docs/developer-docs/integrations/sns/launching/launch-summary.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/launching/launch-summary.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/launching/launch-summary.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/launching/launch-summary.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/launching/launch-summary.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/launching/launch-summary.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/launching/launch-summary.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Thurau <[email protected]>
…into sns-launch-fixes2
Co-authored-by: Daniel Thurau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the developer commands and structure for SNS docs. Large refactor of the SNS docs. I do not think this is anywhere near complete, but I think this is a large enough improvement, that I rather cut the branch here and iterate the rest on another PR.
Preview pages
Pages with the most amount of updates are:
Main changes
Restructured the directory and file names for all things SNS
Added "states" to every step of the SNS launch summary so the reader can see what is changing
Example #1:
Example #2:
Added instructions for downloading and using tools needed