-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNS Asset Canister page #1613
SNS Asset Canister page #1613
Conversation
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
Note the tests seem to be failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for working on this.
I raised two high level questions / concerns on slack.
Very happy to have another look, but thought it might be easiest to clarify them first.
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
ec1f02a
to
8c7aa26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still not sure what version we write the doc for - the "old" version where a dev on a list can do the upgrade or the "new" version where the upgarde happens by proposal.
The intro seems to describe the former, while the details seem to show the latter.
Let me follow up with the SDK team on slack!
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After learning that we want to describe the new flow, I made another pass.
I suggest 2 larger changes:
- I think it would be very helpful to introduce the different roles and maybe also how one can find them out when given an asset canister (I assume there is a command)
- It would be helpful to have a section about what needs to be done during an SNS launch to ensure that the proposal in the last section work (hand over cansiter, set roles correctly, register generic proposals)
WDYT? Happy to discuss further!
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
…nister.md Co-authored-by: Lara Schmid <[email protected]>
…nister.md Co-authored-by: Lara Schmid <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sending a first batch of comments - hope to send more after next meeting.
I think the new description of permissions is super helpful - thanks a lot for the changes!
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
…nister.md Co-authored-by: Lara Schmid <[email protected]>
…nister.md Co-authored-by: Lara Schmid <[email protected]>
…nister.md Co-authored-by: Lara Schmid <[email protected]>
…nister.md Co-authored-by: Lara Schmid <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with the second part. Please feel free to merge whenever you feel ready (as I don't want to add another day just due to the time zone).
I think it is looking pretty good now!
docs/developer-docs/integrations/sns/managing-sns/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
…nister.md Co-authored-by: Lara Schmid <[email protected]>
Thank you for your contribution to the IC Developer Portal.
Before submitting your Pull Request, please make sure that:
.github/CODEOWNERS
file according to your changes./sidebars.js
if any.